On Fri, Jan 05, 2007 at 05:15:36PM +0100, Szabolcs Nagy wrote:
> On 1/5/07, Anselm R. Garbe <arg_AT_suckless.org> wrote:
> >On Fri, Jan 05, 2007 at 03:58:47PM +0100, Szabolcs Nagy wrote:
> >> why do you swap with memory copy (in view.c/swap())?
> >> why just changing the pointers (prev, next) not enough?
> >
> >The reason is that clients, stack or sel might be affected
>
> hmm maybe snext need to be swapped as well then? (otherwise c where
> c->snext==NULL can get to stack top and deataching it would cause
> problem)
Yea that's true indeed. Could have been the reason. However, I
agree that current swap() sucks... Maybe a general pop() for any
client on zoom is better, at least it would be simplier.
Regards,
-- Anselm R. Garbe >< http://suckless.org/~arg/ >< GPG key: 0D73F361Received on Fri Jan 05 2007 - 21:50:39 UTC
This archive was generated by hypermail 2.2.0 : Sun Jul 13 2008 - 14:34:19 UTC