Fwd: [hackers] [dwm] I don't see any reason why we should select for input on override-redirect windows?

Hi there,

I'd like to ask those using dwm in a multihead setup to test hg
tip, to make sure it works well before I create 3.5.

When hacking 2wm I noticed following code in maprequest() and it
seemed odd to me, why selecting for input of override_redirect
windows...? I can only consider this has been added by some
multihead patch!?

diff -r 03ea3a9f6788 -r 154b5d4b4a26 event.c
--- a/event.c Mon Feb 12 14:20:47 2007 +0100
+++ b/event.c Mon Feb 12 16:41:46 2007 +0100
@@ -293,11 +293,8 @@ maprequest(XEvent *e) {
 
         if(!XGetWindowAttributes(dpy, ev->window, &wa))
                 return;
- if(wa.override_redirect) {
- XSelectInput(dpy, ev->window,
- (StructureNotifyMask | PropertyChangeMask));
- return;
- }
+ if(wa.override_redirect)
+ return;
         if(!getclient(ev->window))
                 manage(ev->window, &wa);
 }

-- 
 Anselm R. Garbe >< http://www.suckless.org/ >< GPG key: 0D73F361