Re: [dwm] minor fix for moveresize patch

I think that would be good to add a directory inside dwm for this kind
of patches, so, they're not going to be changed, and it would be easy
to install, so, no need to search for patches but, adding it to the web
would be ok for me too:

  http://www.suckless.org/wiki/dwm/patches

I don't know how to create a new entry in the left menu panel.

--pancake

On Mon, 19 Mar 2007 20:54:07 +0100
"Anselm R. Garbe" <arg_AT_suckless.org> wrote:

> On Sat, Mar 17, 2007 at 09:54:25PM +0100, pancake wrote:
> > I've found a bug in the moveresize patch. You can resize
> > windows when you are in floating mode if the window is not
> > marked as floating individually, so, the fix is easy:
> >
> > --------------client.c----------------------
> > void
> > moveresize(const char *arg) {
> > int x, y, w, h, nx, ny, nw, nh;
> > char xabs, yabs, wabs, habs;
> >
> > if(lt->arrange != floating) // <<--- this is the patch
> > if(!sel || !sel->isfloating || sel->isfixed || !arg)
> > return;
> > if(sscanf(arg, "%d%c %d%c %d%c %d%c %d%c", &x, &xabs, &y, &yabs, &w, &wabs, &h, &habs) != 8)
> > return;
> > nx = xabs == 'x' ? sel->x + x : x;
> > ny = yabs == 'y' ? sel->y + y : y;
> > nw = wabs == 'w' ? sel->w + w : w;
> > nh = habs == 'h' ? sel->h + h : h;
> > resize(sel, nx, ny, nw, nh, True);
> > }
> > ----------client.c--------------------------
> >
> > my config is:
> >
> > { MODKEY|ControlMask, XK_h, moveresize, "-64x 0y 0w 0h" }, \
> > { MODKEY|ControlMask, XK_l, moveresize, "64x 0y 0w 0h" }, \
> > { MODKEY|ControlMask, XK_j, moveresize, "0x 64y 0w 0h" }, \
> > { MODKEY|ControlMask, XK_k, moveresize, "0x -64y 0w 0h" }, \
> > { MODKEY|ShiftMask|ControlMask, XK_h, moveresize, "0x 0y -32w 0h" }, \
> > { MODKEY|ShiftMask|ControlMask, XK_l, moveresize, "0x 0y 32w 0h" }, \
> > { MODKEY|ShiftMask|ControlMask, XK_j, moveresize, "0x 0y 0w 32h" }, \
> > { MODKEY|ShiftMask|ControlMask, XK_k, moveresize, "0x 0y 0w -32h" }, \
> >
> > Have fun!
> >
> > PD: I would like to see the moveresize patch included into the mainstream dwm. ARG what do you think?
>
> I'm not sure it is worth being added, simply because I want
> avoid adding a never-called function (and I can't think of
> decent shortcuts without changing the vanilla shortcuts).
>
> So I say no for the moment.
>
> Regards,
> --
> Anselm R. Garbe >< http://www.suckless.org/ >< GPG key: 0D73F361
>

  --pancake
Received on Mon Mar 19 2007 - 21:44:12 UTC