Re: [dwm] Minor bug: fullscreen apps keeping their border

On Wed, Apr 11, 2007 at 03:21:38PM +0200, Anselm R. Garbe wrote:
> Thanks for your report. I'll investigate into a fix before next
> release.
>
> Regards,
> Anselm
>
> On Wed, Apr 04, 2007 at 10:29:34PM +1000, Tony Lainson wrote:
> > When Firefox is floating and I switch it to fullscreen mode (by pressing
> > F11), the border remains [1] until I move the window with my mouse,
> > whereupon it disappears.
> >
> > [1]: http://users.on.net/~panaceid/dwm-bug/firefox.png (notice how the
> > right and bottom edges have been cut off)
> >
> > works: tile layout, c->isfloating False
> > (no change)
> > BROKEN: tile layout, c->isfloating True
> > BROKEN: floating layout, c->isfloating False
> > BROKEN: floating layout, c->isfloating True
> >
> > ------------------------------------------------------------------------
> >
> > The same problem (border displacing the window) can be seen [2] with
> > MPlayer, but triggering it is a little more complicated.
> >
> > [2]: http://users.on.net/~panaceid/dwm-bug/mplayer.png
> >
> > works: tile layout, config.h rule floating mplayer windows
> > BROKEN: floating layout, config.h rule floating mplayer windows
> > (this is the only (slightly) annoying aspect of the bug)
> > BROKEN: tile layout, NO config.h rule
> > (SOMETIMES *FULLSCREEN* when started with -fs option - race?)
> > BROKEN: floating layout, NO config.h rule
> > (SOMETIMES works when started with -fs option - race?)
> >
> > ------------------------------------------------------------------------

I got a suspicion what might cause this misbehavior.
Actually, I believe it might be related to the misuse of
c->border which is used in the code being set to BORDERPX which
is not correct (due a cleanup sometime ago). c->border has
always been intended as a temporaray value of the window_border
value requested by the client (this is important for
configurerequest handling). So all in all I believe I'll remove
c->border from the struct and use a temp variable instead.

This will need some testing, I let you know when testing will
be required.

Regards,

-- 
 Anselm R. Garbe >< http://www.suckless.org/ >< GPG key: 0D73F361