Re: [dwm] dwm-4.1 / dmenu-3.1

From: Szabolcs Nagy <nszabolcs_AT_gmail.com>
Date: Mon, 21 May 2007 22:02:17 +0200

> dwm-4.1 contains support for Xrandr-based resizals, several bug
according to xrandr(3)
"Clients must call back into Xlib using XRRUpdateConfiguration when
screen configuration change notify events are generated"
it works fine for me this way so probably doesn't matter, but this
suggests to put XRRUpdateConfiguration(e) in configurenotify().

also there is an unnecessary for() in setlayout()
(well i like lt = layout + i; better than lt = &layout[i];)

diff -r 3ece6b5b9647 layout.c
--- a/layout.c Mon May 21 14:37:26 2007 +0200
+++ b/layout.c Mon May 21 21:55:07 2007 +0200
@@ -198,11 +198,9 @@ setlayout(const char *arg) {
         int i;

         if(!arg) {
- for(i = 0; i < nlayouts && lt != &layout[i]; i++);
- if(i == nlayouts - 1)
- lt = &layout[0];
- else
- lt = &layout[++i];
+ lt++;
+ if(lt == layout + nlayouts)
+ lt = layout;
         }
         else {
                 i = atoi(arg);
Received on Mon May 21 2007 - 22:02:19 UTC

This archive was generated by hypermail 2.2.0 : Sun Jul 13 2008 - 14:42:00 UTC