Re: [dwm] fixed windows must be always floating - error+patch

Hi,

I was testing the new behavior (resize fixed size windows on
togglefloat) a bit, and I noticed that not all windows behave correct
yet. Fixed size ones do, but inc-handling and aspect ratio needing
windows don't. See the attached patch for a fix (it simply calls
resize() on any newly floating window, which will handle any sizehints
(including fixed size) that the client has set (and dwm supports)).

Greetings, Sander.

On 5/25/07, Sander van Dijk <a.h.vandijk_AT_gmail.com> wrote:
> On 5/25/07, dfenze_AT_gmail.com <dfenze_AT_gmail.com> wrote:
> > On (23/05/07 07:48), Anselm R. Garbe wrote:
> > > Ah yes, I remember this decision now, I revert the change.
> > >
> > > Regards,
> >
> > Ok,
> > then please include this patch:
> >
> > =================
> > diff -r 42bf8e618d52 client.c
> > --- a/client.c Tue May 22 11:29:59 2007 +0200
> > +++ b/client.c Wed May 23 13:22:20 2007 +0200
> > @@ -305,6 +305,8 @@ togglefloating(const char *arg) {
> > if(!sel || lt->arrange == floating)
> > return;
> > sel->isfloating = !sel->isfloating;
> > + if (sel->isfloating && sel->isfixed)
> > + resize(sel, sel->x, sel->y, sel->minw, sel->minh, True);
> > lt->arrange();
> > }
> >
> > =================
> >
> > So, if fixed client is forced to be non-floating, then if it is switched
> > back to floating, its fixed dimensions are forced.
>
> He, if someone would have asked me, I would have said dwm already did
> this :-). Apparently it doesn't, but you're right that it should.
>
> Greetings, Sander.
>