Basically I came to the same conclusion, that adding const char
*arg to tile() is not the best idea, same with letting the
arrange function do all nasty jobs. All I have in mind is
making the inclusion of third-party layouts more elegant with
less coupling for this. I came up to a different idea which I
will show in detail today. The basic idea is to put all layout
specific stuff into a separate .c and .h file, which is included
in config.h resp. layout.h. So adding a different layout will
only mean to edit config.h. But let's figure the details later.
Regards,
Anselm
On Fri, Aug 10, 2007 at 06:56:36PM +0200, Enno Gottox Boland wrote:
> I think this would decrease code quality. It's a nice idea, but I
> can't see any advantage when using one big function with a huge number
> of lines and inteprete every crap over handle it by extra function
> which will do it in the way but with cleaner code.
>
> 2007/8/10, Anselm R. Garbe <arg_AT_suckless.org>:
> > ... I believe that all lt->arrange !=/== checks only belong to
> > the layout function, which means that layout-specific functions
> > like togglemax(), zoom() should be handled by the argument to the
> > specific arrange function.
> >
> > Regards,
> > --
> > Anselm R. Garbe >< http://www.suckless.org/ >< GPG key: 0D73F361
> >
> >
>
>
> --
> http://www.gnuffy.org - Real Community Distro
> http://www.gnuffy.org/index.php/GnuEm - Gnuffy on Ipaq (Codename Peggy)
>
-- Anselm R. Garbe >< http://www.suckless.org/ >< GPG key: 0D73F361Received on Sat Aug 11 2007 - 11:32:09 UTC
This archive was generated by hypermail 2.2.0 : Sun Jul 13 2008 - 14:48:51 UTC