Re: [dwm] setmwfact bug

Szabolcs Nagy <nszabolcs_AT_gmail.com> writes:

> there's a typo in in dwm.c in setmwfact():
>
> ...
> else if(1 == sscanf(arg, "%lf", &delta)) {
> if(arg[0] == '+' || arg[0] == '-')
> mwfact += delta;
> else
> mwfact = delta; // should be -=
> ...
> }

I don't think it should be. The current behaviour is that
setmwfact("+0.1") adds 0.1 to mwfact, setmwfact("-0.1") subtracts 0.1
from mwfact, and setmwfact("0.1") sets mwfact equal to 0.1. Your =- would
make setmwfact("0.1") equivalent to setmwfact("-0.1").

Cheers,

hrus.
Received on Mon Oct 01 2007 - 20:21:18 UTC