Re: [dwm] Fibonacci patch ported to 4.6

On Thu, Oct 11, 2007 at 07:49:57PM +0200, Xavier wrote:
> On Thu, Oct 11, 2007 at 07:36:26PM +0200, Anselm R. Garbe wrote:
> > On Thu, Oct 11, 2007 at 07:08:14PM +0200, Xavier wrote:
> > > Some users requested the fibonacci patch, which was only for 4.4.1.
> > > Even though I didn't use it, I tried to port it to 4.6, and it seems to work
> > > fine. Please review it :)
> > >
> > > Also, arg said earlier [1] that it should still be possible to keep a header file
> > > (fibonacci.h in this case) and include it in config.h, instead of including
> > > fibonacci.c directly.
> > > I tried to do it, but failed :
> > > dwm.c:(.text+0x2ada): undefined reference to `spiral'
> > > dwm.c:(.text+0x2ae1): undefined reference to `dwindle'
> > >
> > > It would be nice if someone could show me how to do this, I'm curious :)
> >
> > You only need to add SRC = fibonacci.c in config.mk as well.
> >
>
> Oh ok, I didn't get this part. Thanks.
> But now, I have other errors, fibonacci.c doesn't have access to any
> declarations in dwm.c.
> For example, the first error :
> fibonacci.c: In function `fibonacci':
> fibonacci.c:8: error: `Client' undeclared (first use in this function)
>
> Previously, this was achieved by including dwm.h in fibonacci.c, but this
> file doesn't exist anymore.
> I didn't understand what you suggested for replacing that either.

That's a good point, lemme consider to recreate dwm.h which
might include the typedefs.

Regards,

-- 
 Anselm R. Garbe >< http://www.suckless.org/ >< GPG key: 0D73F361