Re: [dwm] final test call

"Anselm R. Garbe" <arg_AT_suckless.org> wrote:
> On Fri, Oct 19, 2007 at 01:04:52PM +0200, pancake wrote:
> > #define ISTILE isarrange(tile) /* || isarrange(<custom>) */
>
> I disagree here, because setmwfact() and zoom() for instance are quite tile-related.
> There might be good reasons to not extend ISTILE with || isarrange(grid).

the comment in the following line is misleading since it won't work if
you don't use additional parenthesis:

config.def.h:#define ISTILE isarrange(tile) /* || isarrange(<custom>) */

but i'd rather suggest changing dwm.c here:

$ hg diff
-----------------------------------------------
diff -r c354f178a198 dwm.c
--- a/dwm.c Sat Oct 20 05:49:04 2007 +0200
+++ b/dwm.c Sat Oct 20 05:55:11 2007 +0200
@@ -380,7 +380,7 @@ buttonpress(XEvent *e) {
                        movemouse(c);
                }
                else if(ev->button == Button2) {
- if(ISTILE && !c->isfixed && c->isfloating)
+ if((ISTILE) && !c->isfixed && c->isfloating)
                                togglefloating(NULL);
                        else
                                zoom(NULL);
@@ -1455,7 +1455,7 @@ setmwfact(const char *arg) {
 setmwfact(const char *arg) {
        double delta;
 
- if(!ISTILE)
+ if(!(ISTILE))
                return;
        /* arg handling, manipulate mwfact */
        if(arg == NULL)
@@ -1922,7 +1922,7 @@ zoom(const char *arg) {
 zoom(const char *arg) {
        Client *c;
 
- if(!sel || !ISTILE || sel->isfloating)
+ if(!sel || !(ISTILE) || sel->isfloating)
                return;
        if((c = sel) == nexttiled(clients))
                if(!(c = nexttiled(c->next)))
-----------------------------------------------

btw: your line numbers may differ. been hacking dwm again.

Regards
  - Robert Figura
Received on Sat Oct 20 2007 - 05:38:27 UTC