Re: [dwm] [dvtm] [PATCH 1/2] Correct signal handling

From: Marc Andre Tanner <mat_AT_brain-dump.org>
Date: Thu, 1 May 2008 23:31:34 +0200

On Wed, Apr 30, 2008 at 12:06:23AM +0200, Rainer Müller wrote:
> The global errno variable needs to be saved at the begin of a signal handler
> and to be restored at the end.

Thanks for your patches i took a quick look at them and they seem to be
ok, i am currently a bit busy but if nobody objects i will commit them
soon. See one remark below.
  
> void
> sigterm_handler(int sig){
> + int errsv = errno;
> running = false;
> + errno = errsv;
> }

I don't think a simple variable assignment can change errno, or i am
missing something?

Thanks,
Marc

-- 
 Marc Andre Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0
Received on Thu May 01 2008 - 23:32:57 UTC

This archive was generated by hypermail 2.2.0 : Sun Jul 13 2008 - 15:36:43 UTC