Re: [dwm] current hg tip

On (15/08/08 13:07), Martin Hurton wrote:
> To: dwm_AT_suckless.org
> From: Martin Hurton <martin.hurton_AT_gmail.com>
> Subject: [dwm] current hg tip
> Mail-Followup-To: dwm_AT_suckless.org
> Reply-To: dwm mail list <dwm_AT_suckless.org>
> List-Id: dwm mail list <dwm.suckless.org>
> User-Agent: Mutt/1.5.18 (2008-05-17)
>
> I think the commit bca7a556aa03 in the official dwm repo introduced a
> new bug.
>
> The following is the excerpt fro the Xlib manual:
> "Some functions return Status, an integer error indication. If the
> function fails, it returns a zero. If the function returns a status of
> zero, it has not updated the return arguments."
>
> So, if the XGetTransientForHint() function fails, the trans variable
> is not updated and its value is undefined.
>
> I suggest to revert this commit and apply the patch a proposed
> yesterday.
>
> /Martin
>

It is updated (set to be None in case there is not WM_TRANSIENT_HINT property
on window), and there are also other places in the code which depends on
this, so I changed it to be consistent in handling of
XGetTransientForHint.

-Ph

-- 
Premysl "Anydot" Hruby, http://www.redrum.cz/