Re: [dwm] [patch] resizemouse() cleanup

On Mon, Aug 18, 2008 at 11:25:59AM -0700, Chris Monson wrote:
> Looks like it was a superfluous space before a comma :-)
Yes, it was the space in XWarpPointer's argument list.

>
> On Mon, Aug 18, 2008 at 11:20 AM, Anselm R Garbe <garbeam_AT_gmail.com> wrote:
>
> > Applied, thanks -- I expected this ;)
> > The small typo was the wrong tab indentation?
> >
> > Kind regards,
> > Anselm
> >
> > 2008/8/18 Martin Hurton <martin.hurton_AT_gmail.com>:
> > > Hi,
> > >
> > > This patch changes the resizemouse() function the same way as the
> > > previous patch changed the movemouse() one. It also fixes one small
> > > typo. Comments are welcome.
> > >
> > > Cheers,
> > > /Martin
> > >
> > > diff -r 6f9cf8bcc4a7 dwm.c
> > > --- a/dwm.c Mon Aug 18 18:23:39 2008 +0100
> > > +++ b/dwm.c Mon Aug 18 19:53:39 2008 +0200
> > > @@ -1127,15 +1127,9 @@
> > > None, cursor[CurResize], CurrentTime) != GrabSuccess)
> > > return;
> > > XWarpPointer(dpy, None, c->win, 0, 0, 0, 0, c->w + c->bw - 1, c->h
> > + c->bw - 1);
> > > - for(;;) {
> > > - XMaskEvent(dpy,
> > MOUSEMASK|ExposureMask|SubstructureRedirectMask , &ev);
> > > + do {
> > > + XMaskEvent(dpy,
> > MOUSEMASK|ExposureMask|SubstructureRedirectMask, &ev);
> > > switch(ev.type) {
> > > - case ButtonRelease:
> > > - XWarpPointer(dpy, None, c->win, 0, 0, 0, 0,
> > > - c->w + c->bw - 1, c->h + c->bw -
> > 1);
> > > - XUngrabPointer(dpy, CurrentTime);
> > > - while(XCheckMaskEvent(dpy, EnterWindowMask,
> > &ev));
> > > - return;
> > > case ConfigureRequest:
> > > case Expose:
> > > case MapRequest:
> > > @@ -1156,7 +1150,10 @@
> > > resize(c, c->x, c->y, nw, nh, True);
> > > break;
> > > }
> > > - }
> > > + } while(ev.type != ButtonRelease);
> > > + XWarpPointer(dpy, None, c->win, 0, 0, 0, 0, c->w + c->bw - 1,
> > c->h + c->bw - 1);
> > > + XUngrabPointer(dpy, CurrentTime);
> > > + while(XCheckMaskEvent(dpy, EnterWindowMask, &ev));
> > > }
> > >
> > > void
> >
> >
Received on Mon Aug 18 2008 - 18:32:27 UTC