Re: [dwm] [dmenu] OPTFLAGS in config.mk + patch

2009/4/8 Jan Blazek <appolito2_AT_gmail.com>:
> Hi,
>
> I would like to make package of dmenu for Fedora and in the review process
> someone (Till Maas) suggested it would be better to have ability to pass gcc
> optimization flags to make on the command line. [1]
>
> Best regards,
> Jan Blazek
>
> PS: Patch attached.
>
> [1] https://bugzilla.redhat.com/show_bug.cgi?id=485638#c3
>
> --- dmenu-3.9/config.mk.optflags        2008-09-09 15:45:00.000000000 -0400
> +++ dmenu-3.9/config.mk 2009-04-02 15:26:41.000000000 -0400
> @@ -20,7 +20,8 @@ LIBS = -L/usr/lib -lc -L${X11LIB} -lX11
>
>  # flags
>  CPPFLAGS = -DVERSION=\"${VERSION}\" ${XINERAMAFLAGS}
> -CFLAGS = -std=c99 -pedantic -Wall -Os ${INCS} ${CPPFLAGS}
> +OPTFLAGS = -Os

This wont make any difference, you can't pass it from the command line
like this anyway.
You're overwriting OPTFLAGS here all the time to -Os. You'll have to
use the following for it to work:
OPTFLAGS ?= -Os

> +CFLAGS = -std=c99 -pedantic -Wall ${OPTFLAGS} ${INCS} ${CPPFLAGS}
>  LDFLAGS = -s ${LIBS}
>
>  # Solaris
>
>

--
Daniel