Re: [hackers] [dwm] prepared 3.7, ready to rambo

>>> sender: "Anselm R. Garbe" date: "Sat, Feb 24, 2007 at 02:41:45PM +0000" <<<EOQ
> changeset: 845:baee494346e5
> tag: 3.7
> user: Anselm R. Garbe <arg_AT_suckless.org>
> date: Sat Feb 24 15:40:50 2007 +0100
> summary: prepared 3.7, ready to rambo
Hi there,

If you decide to keep grid layout in dwm (which would be great ;-))
then there is an error in layout.c:39
     c->isversatile
should be changed to isfloating.

Also here are a last couple of very good suggestions that Jukka Salmi
sent me:

> just a few comments on your patch: you don't need to set nw and nh
> inside the for loop since they never change. I'd set them before the
> loop. What a performace boost ;-)
>
> Furthermore, if you wrote e.g.
>
> th = (sh - dc.h) / (rows?rows:1);
> tw = sw / (cols?cols:1);
>
> instead of setting th and tw only if n>0, you'd get rid of the gcc
> warning.

Cheers,
Alex
Received on Sat Feb 24 2007 - 15:50:59 UTC