[hackers] [dwm] reverted spawn || arg

changeset: 1365:b34298951f7b
tag: tip
user: arg_AT_localhost.localdomain
date: Sat Dec 06 09:16:48 2008 +0000
files: dwm.c
description:
reverted spawn

diff -r a93d5d1a3389 -r b34298951f7b dwm.c
--- a/dwm.c Thu Dec 04 20:23:08 2008 +0000
+++ b/dwm.c Sat Dec 06 09:16:48 2008 +0000
@@ -182,7 +182,6 @@
 static void setmfact(const Arg *arg);
 static void setup(void);
 static void showhide(Client *c);
-static void sigchld(int signal);
 static void spawn(const Arg *arg);
 static void tag(const Arg *arg);
 static int textnw(const char *text, unsigned int len);
@@ -1392,24 +1391,22 @@
         }
 }
 
-
-void
-sigchld(int signal) {
- while(0 < waitpid(-1, NULL, WNOHANG));
-}
-
 void
 spawn(const Arg *arg) {
- signal(SIGCHLD, sigchld);
+ /* The double-fork construct avoids zombie processes and keeps the code
+ * clean from stupid signal handlers. */
         if(fork() == 0) {
- if(dpy)
- close(ConnectionNumber(dpy));
- setsid();
- execvp(((char **)arg->v)[0], (char **)arg->v);
- fprintf(stderr, "dwm: execvp %s", ((char **)arg->v)[0]);
- perror(" failed");
+ if(fork() == 0) {
+ if(dpy)
+ close(ConnectionNumber(dpy));
+ setsid();
+ execvp(((char **)arg->v)[0], (char **)arg->v);
+ fprintf(stderr, "dwm: execvp %s", ((char **)arg->v)[0]);
+ perror(" failed");
+ }
                 exit(0);
         }
+ wait(0);
 }
 
 void
Received on Sat Dec 06 2008 - 09:16:50 UTC