[hackers] [surf] There are people not reading the existing code. || Christoph Lohmann

From: <git_AT_suckless.org>
Date: Fri, 15 Mar 2013 18:40:14 +0100

commit 12101938d8df3da51871ed5d1da7c6144c2138cb
Author: Christoph Lohmann <20h_AT_r-36.net>
Date: Fri Mar 15 18:37:12 2013 +0100

    There are people not reading the existing code.
    
    I fucking hate to have to correct all of this. People learn to read!

diff --git a/surf.c b/surf.c
index 56bf6b0..e0ad8ea 100644
--- a/surf.c
+++ b/surf.c
_AT_@ -80,7 +80,7 @@ static gboolean usingproxy = 0;
 static char togglestat[6];
 static char pagestat[3];
 
-static void add_accels(Client *c);
+static void addaccelgroup(Client *c);
 static void beforerequest(WebKitWebView *w, WebKitWebFrame *f,
                 WebKitWebResource *r, WebKitNetworkRequest *req,
                 WebKitNetworkResponse *resp, gpointer d);
_AT_@ -169,11 +169,13 @@ static void zoom(Client *c, const Arg *arg);
 #include "config.h"
 
 static void
-add_accels(Client *c) {
+addaccelgroup(Client *c) {
         int i;
         GtkAccelGroup *group = gtk_accel_group_new();
+ GClosure *closure;
+
         for(i = 0; i < LENGTH(keys); i++) {
- GClosure *closure = g_cclosure_new(G_CALLBACK(keypress), c, NULL);
+ closure = g_cclosure_new(G_CALLBACK(keypress), c, NULL);
                 gtk_accel_group_connect(group, keys[i].keyval, keys[i].mod,
                                 0, closure);
         }
_AT_@ -663,9 +665,9 @@ newclient(void) {
         g_signal_connect(G_OBJECT(c->win),
                         "destroy",
                         G_CALLBACK(destroywin), c);
- if(!kioskmode) {
- add_accels(c);
- }
+
+ if(!kioskmode)
+ addaccelgroup(c);
 
         /* Pane */
         c->pane = gtk_vpaned_new();
Received on Fri Mar 15 2013 - 18:40:14 CET