[hackers] [surf] Removing a memory leak when u wasn't freed. || Christoph Lohmann

From: <git_AT_suckless.org>
Date: Thu, 06 Feb 2014 06:50:51 +0100

commit 127dc366efeda9afc6086be67b60979af1d71205
Author: Christoph Lohmann <20h_AT_r-36.net>
Date: Thu Feb 6 06:47:22 2014 +0100

    Removing a memory leak when u wasn't freed.

diff --git a/surf.c b/surf.c
index c598404..1ec4c62 100644
--- a/surf.c
+++ b/surf.c
_AT_@ -656,7 +656,7 @@ loadstatuschange(WebKitWebView *view, GParamSpec *pspec, Client *c) {
 
 static void
 loaduri(Client *c, const Arg *arg) {
- char *u, *rp;
+ char *u = NULL, *rp;
         const char *uri = (char *)arg->v;
         Arg a = { .b = FALSE };
         struct stat st;
_AT_@ -683,9 +683,10 @@ loaduri(Client *c, const Arg *arg) {
                 webkit_web_view_load_uri(c->view, u);
                 c->progress = 0;
                 c->title = copystr(&c->title, u);
- g_free(u);
                 updatetitle(c);
         }
+ if(u != NULL)
+ g_free(u);
 }
 
 static void
Received on Thu Feb 06 2014 - 06:50:51 CET