Re: [hackers] [ubase] Fix style issue || sin

From: Aaron Burrow <burrows.labs_AT_gmail.com>
Date: Thu, 6 Mar 2014 10:11:25 -0500

Do you prefer this style because the '!' is easy to 'unsee' at 3 in the
morning?


On Thu, Mar 6, 2014 at 10:09 AM, <git_AT_suckless.org> wrote:

> commit a3e437c7ef0fab5197c53549a22fbc0db5c2570d
> Author: sin <sin_AT_2f30.org>
> Date: Thu Mar 6 15:06:47 2014 +0000
>
> Fix style issue
>
> diff --git a/killall5.c b/killall5.c
> index acadbf3..7f91e06 100644
> --- a/killall5.c
> +++ b/killall5.c
> _AT__AT_ -61,7 +61,7 @@ main(int argc, char *argv[])
> if (!(dp = opendir("/proc")))
> eprintf("opendir /proc:");
> while ((entry = readdir(dp))) {
> - if (!pidfile(entry->d_name))
> + if (pidfile(entry->d_name) == 0)
> continue;
> pid = estrtol(entry->d_name, 10);
> if (pid == 1 || pid == getpid() ||
>
>
>
Received on Thu Mar 06 2014 - 16:11:25 CET