On Sun, 01 Jun 2014 17:10:40 +0200
git_AT_suckless.org wrote:
> By the recommendation of FRIGN I refactored xsetcolorname to remove the
> unnecessary r, g, b variables when allocating a new color. Colors are
> now freed and set to the new color. A die() should not happen here. Oth‐
> erwise it is easy for applications to kill st. St should be resilent to
> malicious input.
Thanks for fixing that and spotting the memory leak. I'll take more
care next time handling this.
> Second this patch standardises the naming of »color«. There is no
> »colour« here. Maybe in some parts of the world.
It's nice to see the naming-convention has finally been realized. It
was a real mess to have both "color" and "colour" in the local scope
and this will make the code more readable :).
Next up: Font cache.
Cheers
FRIGN
--
FRIGN <dev_AT_frign.de>
Received on Sun Jun 01 2014 - 17:49:45 CEST