Re: [hackers] [st] [patch] use goto in xloadfonts

From: Markus Teich <markus.teich_AT_stusta.mhn.de>
Date: Sat, 20 Jun 2015 00:21:10 +0200

Michael Reed wrote:
> st.c | 14 +++++++++-----
> 1 file changed, 9 insertions(+), 5 deletions(-)

Heyho Michael,

I don't think that is a good use of goto at all. You just made the programmflow
harder to grasp and removed the possibility to differentiate between the errors
in the future. Also the patch adds 4 SLoC without achieving anything.

--Markus
Received on Sat Jun 20 2015 - 00:21:10 CEST