Re: [hackers] [dmenu] Untypedef struct item || FRIGN

From: Dimitris Papastamos <sin_AT_2f30.org>
Date: Mon, 28 Sep 2015 00:14:56 +0100

On Mon, Sep 28, 2015 at 12:38:37AM +0200, git_AT_suckless.org wrote:
> commit 10fd4f275feaef0b505cc8e65a2deccae69a0968
> Author: FRIGN <dev_AT_frign.de>
> AuthorDate: Mon Sep 28 00:15:03 2015 +0200
> Commit: Hiltjo Posthuma <hiltjo_AT_codemadness.org>
> CommitDate: Mon Sep 28 00:33:26 2015 +0200
>
> Untypedef struct item
>
> Adds clarity. Typedefs for structs are definitely a discussion matter,
> but there's no reason to hide a simple data-structure behind a
> meaningless typedef.

Why?

For both dwm and dmenu, the use of typedef was very specific. I see
no point performing these kind of changes only for the sake of cross-project
consistency.

The problem with this change is that it adds nothing of value. In
some cases this attitude may even break perfectly functional code.

Of course this is up to the maintainer, I just wanted to raise this issue
because there's a lot of these kind of changes happening across projects.
Received on Mon Sep 28 2015 - 01:14:56 CEST