[hackers] [surf] Fix atom value parsing in SETPROP || Quentin Rameau
commit 1554354f1689c2205a809e23d29c9e21d38e0be5
Author: Quentin Rameau <quinq+hackers_AT_fifth.space>
AuthorDate: Tue Oct 13 13:32:09 2015 +0200
Commit: Christoph Lohmann <20h_AT_r-36.net>
CommitDate: Tue Oct 13 14:28:09 2015 +0200
Fix atom value parsing in SETPROP
xprop(1) encloses the returned atom string value in double quotes while
it doesn't when the value is unset. Original simple parsing would fail
and parse the atom name instead of getting an empty value.
Signed-off-by: Christoph Lohmann <20h_AT_r-36.net>
diff --git a/config.def.h b/config.def.h
index 1eb9566..5245129 100644
--- a/config.def.h
+++ b/config.def.h
_AT_@ -37,7 +37,9 @@ static Bool allowgeolocation = TRUE;
#define SETPROP(p, q) { \
.v = (char *[]){ "/bin/sh", "-c", \
- "prop=\"`xprop -id $2 $0 | cut -d '\"' -f 2 | xargs -0 printf %b | dmenu`\" &&" \
+ "prop=\"`xprop -id $2 $0 " \
+ "| sed \"s/^$0(STRING) = \\(\\\\\"\\?\\)\\(.*\\)\\1$/\\2/\" " \
+ "| xargs -0 printf %b | dmenu`\" &&" \
"xprop -id $2 -f $1 8s -set $1 \"$prop\"", \
p, q, winid, NULL \
} \
Received on Tue Oct 13 2015 - 14:29:22 CEST
This archive was generated by hypermail 2.3.0
: Tue Oct 13 2015 - 14:36:12 CEST