Re: [hackers] [ubase][PATCH] mount: fix indentation

From: Petr Vaněk <arkamar_AT_atlas.cz>
Date: Thu, 28 Apr 2016 14:14:15 +0200

On Thu, Apr 28, 2016 at 02:10:31PM +0200, Mattias Andrée wrote:
> On Thu, 28 Apr 2016 14:10:13 +0200
> Petr Vaněk <arkamar_AT_atlas.cz> wrote:
>
> > On Thu, Apr 28, 2016 at 01:06:36PM +0200, Mattias Andrée
> > wrote:
> > > On Thu, 28 Apr 2016 13:04:47 +0200
> > > Petr Vaněk <arkamar_AT_atlas.cz> wrote:
> > >
> > > > Without any functional change.
> > > > ---
> > > > mount.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/mount.c b/mount.c
> > > > index 2eb175c..ba97412 100644
> > > > --- a/mount.c
> > > > +++ b/mount.c
> > > > _AT_@ -263,7 +263,7 @@ main(int argc, char *argv[])
> > > > }
> > > > if (!fsopts[0])
> > > > estrlcat(fsopts,
> > > > me->mnt_opts, sizeof(fsopts));
> > > > -
> > > > parseopts(fsopts, &flags, data, sizeof(data));
> > > > + parseopts(fsopts,
> > > > &flags, data, sizeof(data)); if (!types)
> > > > types =
> > > > me->mnt_type; goto mountsingle;
> > >
> > > To me it looks like { } are missing, but the
> > > indentation is correct. Are you sure it is the
> > > indentation that is wrong?
> >
> > I did some testing of both, with and without { }. It sets
> > the fsopts correctly in both cases.
> >
> > Petr
> >
>
> Then it should be { }.

Ok, I will send the patch soon.
Received on Thu Apr 28 2016 - 14:14:15 CEST