Re: [hackers] [dwm] [PATCH] Replace str[n]cpy with strlcpy

From: FRIGN <dev_AT_frign.de>
Date: Sun, 5 Jun 2016 21:01:23 +0200

On Fri, 3 Jun 2016 17:58:12 +0200
k0ga_AT_shike2.com wrote:

Hey Roberto,

> safe?. You are not checking any of the return codes. You are only
> moving the problem from some place to another place. Please add
> checks and stop using non portable functions. I don't want your
> shit, thanks.

there is also another point here: strlcpy is safer than strcpy
and strncpy because _if_ there is an overflow the string will
be 0-terminated. I'm not sure if there even should be an
error-out in case for instance we overflow writing the
"broken"-state-string to a client-name.

Cheers

FRIGN

-- 
FRIGN <dev_AT_frign.de>
Received on Sun Jun 05 2016 - 21:01:23 CEST

This archive was generated by hypermail 2.3.0 : Sun Jun 05 2016 - 21:12:13 CEST