On Sun, Jun 26, 2016 at 01:05:18PM -0700, Eric Pruitt wrote:
> On Sun, Jun 26, 2016 at 02:53:03PM +0200, Hiltjo Posthuma wrote:
> > I have pushed the drw changes to dmenu and dwm.
> >
> > Thanks for the contributions!
> >
> > It would be nice if people test it and report any regressions with their setups
> > (font-fallback specificly).
>
> I'm in the process of merging this with my personal changes, so I
> haven't actually compiled dwm yet, but I did notice that the colors
> array could be made self-documenting by using enum values instead of
> comments; the code currently likes like this:
>
> static const char *colors[][3] = {
> /* fg bg border */
> { col_gray3, col_gray1, col_gray2}, /* normal */
> { col_gray4, col_cyan, col_cyan }, /* selected */
> };
>
> However, I personally think this is a little nicer:
>
> static const char *colors[][3] = {
> /* fg bg border */
> [SchemeNorm] = { col_gray3, col_gray1, col_gray2},
> [SchemeSel] = { col_gray4, col_cyan, col_cyan },
> };
>
> It also ensures that the order of the array doesn't matter, and it makes
> it a little easier to add new color schemes.
>
I agree, I have pushed a change for the repo to dwm and dmenu for this.
Thanks for your feedback and testing!
--
Kind regards,
Hiltjo
Received on Tue Jun 28 2016 - 18:09:43 CEST