Re: [hackers] [quark] Initial commit of quark rewrite || FRIGN

From: Nick <suckless-hackers_AT_njw.name>
Date: Fri, 2 Sep 2016 12:37:00 +0100

Hi FRIGN,

I don't have time to look at this closely now, but one little thing
that jumped out at me:

> +static const struct {
> + char *ext;
> + char *type;
> +} mimes[] = {
> ...

Why are you defining the struct in config.def.h? Shouldn't it be
defined in quark.c, and then just populated in config.def.h. That is
what other projects do, and it makes more sense, as the code in
quark.c depends on the struct being defined a certain way.

Nick
Received on Fri Sep 02 2016 - 13:37:00 CEST