Re: [hackers] [slock] [PATCHSET] Some improvements and more security

From: Quentin Rameau <quinq_AT_fifth.space>
Date: Mon, 12 Sep 2016 12:20:51 +0200

> Good evening fellow hackers,
Hi FRIGN,

> I sat down this evening to write down some patches that have been
> floating around in my head for a while.
>
> See attached. Most important is the patch which removes the
> abomination of user $USER which actually poses quite a risk and only
> is done on part of the systems. The largest one is the one removing
> global state of the program to make code audits simpler.
First patch:
- I agree with the structuring of the xrandr part, good!
- But not with the localization of every data, they're used across the
  whole program and you're just over-complicating functions here imho.
  The program is simple and clear enough not to have to get triple
  pointers passed as function parameters.
- un-typedef, that's not an issue here, why changing it besides
  satisfying your personal taste?

Second patch:
- fine by me, renaming variables patch ;p

Third patch:
- the rval renaming belongs to the second patch
- I agree with the removal of the $USER, we discussed it before this
  patch on IRC. But maybe we should have the reasoning behind that from
  the original author who put it here.

Anyway, thanks for the work!
Received on Mon Sep 12 2016 - 12:20:51 CEST