Re: [hackers] [dwm] [PATCH] decouple color-scheme count from dwm.c

From: Anselm R Garbe <garbeam_AT_gmail.com>
Date: Wed, 2 Nov 2016 11:47:19 +0100

Hi Markus,

On 31 October 2016 at 13:18, Markus Teich <markus.teich_AT_stusta.mhn.de> wrote:
> Anselm R Garbe wrote:
>> I prefer requiring SchemeLast = N.
>
> sorry I forgot to update that one last week. Do you prefer SchemeLast as enum
> element (The whole enum definition has to move to config.def.h) or as `#define`?
> Either way the declaration of the `scheme` array has to be moved below the
> config.h include which breaks the current structure of `dwm.c`. I really prefer
> the ecalloc version which at least does not fail during runtime on OOM, because
> it is only called in `setup()`.

I wrapped my head around this and agree with your original approach.
Let's drop SchemeLast in favour for heap allocation. This change is
less dramatic than moving the enum to config.h or introducing an ugly
define.

-Anselm
Received on Wed Nov 02 2016 - 11:47:19 CET