Re: [hackers] [dwm] [PATCH] decouple color-scheme count from dwm.c

From: Markus Teich <markus.teich_AT_stusta.mhn.de>
Date: Fri, 11 Nov 2016 23:23:01 +0100

Heyho Anselm,

Markus Teich wrote:
> this patch allows for a flexible amount of different colorschemes in config.h
> without having to edit dwm.c as well.

> This patch simplifies the status bar text padding and fixes the comment with a
> wrong description.

I think enough time has passed for others to review those patches. :)

> diff --git a/config.def.h b/config.def.h
> index ba9a240..deb1584 100644
> --- a/config.def.h
> +++ b/config.def.h
> _AT_@ -56,7 +56,13 @@ static const Layout layouts[] = {
>
> /* commands */
> static char dmenumon[2] = "0"; /* component of dmenucmd, manipulated in spawn() */
> -static const char *dmenucmd[] = { "dmenu_run", "-m", dmenumon, "-fn", dmenufont, "-nb", col_gray1, "-nf", col_gray3, "-sb", col_cyan, "-sf", col_gray4, NULL };
> +static const char *dmenucmd[] = { "dmenu_run", "-m", dmenumon,
> + "-fn", dmenufont,
> + "-nb", col_gray1,
> + "-nf", col_gray3,
> + "-sb", col_cyan,
> + "-sf", col_gray4,
> + NULL };
> static const char *termcmd[] = { "st", NULL };
>
> static Key keys[] = {
> --
> 2.7.3

> Before this patch when receiving a _NET_ACTIVE_WINDOW event from a window
> which is out of view one of the two altenative views/tagsets gets purged and
> replaced with just the tags where the respective window is visible. For
> example if you have tags [1,2,3] selected in the first view and tags [4,5,6]
> on the second view and are currently on the second one, then when a window on
> tag 7 sends the _NET_ACTIVE_WINDOW event the first view is purged and replaced
> by just tags [7]. To get back to your previous setup you have to re-select
> tags 1-3 and then have the views [1,2,3,7] and [4,5,6] where the new window is
> still on the view you were not using previously, but on the other one.
>
> After this patch the event sending window just gets set to urgent leaving the
> user the choice when to handle the event. The patch also removes the behavior
> of such windows getting popped to the top of the master area.
>
> ---
>
> Here is the version which sets the urgency hint on receiving
> _NET_ACTIVE_WINDOW messages. There is no real "extra code", but a small
> refactoring was needed to stay sane: clearurgent() was renamed to seturgent()
> which takes the value to set the urgency hint to as an extra parameter.
>
> Also after the patch the window does not get popped to the top of the master
> area anymore, since I thought that was in the same line of intrusiveness.
>
> This patch even saves 3 SLoC. :)

> Per client resize hints. Since the client struct is always initialized with
> zeroes to preserve behaviour either the meaning has to be reversed
> ("ignorehints"?) or a default rule with class, instance and title set to NULL
> has to be added.

Did you make up your oppinion about these three yet? Please reply in the
original thread if you have more feedback. I just collected all the pending
patches in this one mail to not spam the list by creating a ping for every
single one of them.

--Markus
Received on Fri Nov 11 2016 - 23:23:01 CET