Re: [hackers] [slock][PATCH] Fix resize with multiple monitors and portrait mode

From: Markus Teich <markus.teich_AT_stusta.mhn.de>
Date: Wed, 23 Nov 2016 00:32:51 +0100

Bob Uhl wrote:
> I built slock from 1.4, with the same desktop-revealing result. This is on
> Xorg 1.16.4, which supports RandR 1.4.
>
> I merged my patch into 1.4; it fixes the issue.
>
> The RandR protocol documentation at
> <https://www.x.org/releases/X11R7.5/doc/randrproto/randrproto.txt> indicates
> under 'RRScreenChangeNotify' (just before section 8.1):
>
> Note that the sizes in this event reflect the new SCREENSIZE and thus will
> appear rotated by the 'rotation' parameter from the sizes of the screen
> itself. In other words, when rotation is 90 or 270, widthInPixels in this
> event will be the same as the height value from a ConfigureNotify that
> reflects the same size change. This will probably confuse developers.
>
> I suspect that it's only accidentally working for some folks with portrait
> screens.

Heyho Bob,

thanks for the explanations, I merged your patch with some line-length
modifications.

--Markus
Received on Wed Nov 23 2016 - 00:32:51 CET

This archive was generated by hypermail 2.3.0 : Wed Nov 23 2016 - 00:36:29 CET