Re: [hackers] [dmenu] [PATCH v2] Xinerama: correct variable declarations in preprocessor conditional

From: Quentin Rameau <quinq_AT_fifth.space>
Date: Fri, 25 Nov 2016 13:52:34 +0100

> Sorry Quentin, I know now that this is where to include remarks.
No problem, thanks for correcting!

> dmenu.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/dmenu.c b/dmenu.c
> index 9278e91..1cfefcd 100644
> --- a/dmenu.c
> +++ b/dmenu.c
> _AT_@ -539,15 +539,16 @@ run(void)
> static void
> setup(void)
> {
> - int x, y;
> + int x, y, i = 0;
> + unsigned int du;
> XSetWindowAttributes swa;
> XIM xim;
> + Window w, dw, *dws;
> + XWindowAttributes wa;
> #ifdef XINERAMA
> XineramaScreenInfo *info;
> - Window w, pw, dw, *dws;
> - XWindowAttributes wa;
> - int a, j, di, n, i = 0, area = 0;
> - unsigned int du;
> + Window pw;
> + int a, j, di, n, area = 0;
> #endif
>
> /* init appearance */
Looks fine to me, let's wait for other's approval.
Received on Fri Nov 25 2016 - 13:52:34 CET

This archive was generated by hypermail 2.3.0 : Fri Nov 25 2016 - 14:00:18 CET