Re: [hackers] [sbase] [PATCH 1/5] Remove st != NULL checks from recursor functions

From: Laslo Hunhold <>
Date: Tue, 27 Dec 2016 14:59:56 +0100

On Wed, 14 Dec 2016 19:40:02 -0800
Michael Forney <> wrote:

Hey Michael,

> In the description of 3111908b034c73673a2f079b2b13a88c18379baa, it
> says that the functions must be able to handle st being NULL, but
> recurse always passes a valid pointer. The only function that was
> ever passed NULL was rm(), but this was changed to go through recurse
> in 2f4ab527391135e651b256f8654b050ea4a48f3d, so now the checks are
> pointless.

have you tested this patchset extensively? I hate to admit that the
recursor-subsystem is probably the most fragile part of sbase and
really need more feedback on these patches by more people (Silvan, have
you had the chance to test this?).



Laslo Hunhold <>
Received on Tue Dec 27 2016 - 14:59:56 CET

This archive was generated by hypermail 2.3.0 : Tue Dec 27 2016 - 15:16:04 CET