Re: [hackers] [sbase][Patch] date: add date/time setting capability

From: Michael Forney <mforney_AT_mforney.org>
Date: Sun, 1 Jan 2017 13:43:59 -0800

On 12/29/16, John Vogel <jvogel4_AT_stny.rr.com> wrote:
> On Thu, 29 Dec 2016 12:11:33 +0100
> Hiltjo Posthuma <hiltjo_AT_codemadness.org> wrote:
>
>> Nitpicks:
>> - Check if digit in date_field().
>> - Style: don't declare variables in the inner scope, just use the
>> function scope for struct tm date; and struct timespec ts;
>>
>> Kind regards,
>> Hiltjo
>>
>
> Thanks for your input.

Hmm, I think your fix for this made the patch a bit awkward. I suggest
keeping the original structure, but changing date_field to eprintf
when it hits a non-digit, so you don't have to deal with all that
error checking in main.
Received on Sun Jan 01 2017 - 22:43:59 CET