Re: [hackers] [dwm] [PATCH] focusonclick

From: Markus Teich <markus.teich_AT_stusta.mhn.de>
Date: Thu, 5 Jan 2017 08:07:28 +0100

Eric Pruitt wrote:
> I do not know much about X11 either, but try looking at the source of one of
> these patches which keeps / includes an XAllowEvents call:
>
> - http://lists.suckless.org/dev/1212/13833.html
> - https://github.com/ericpruitt/edge/blob/master/patches/dwm-00-click-to-focus.diff
>
> The second link is just my personal variant of the first patch. Neither of
> them have bugs that prevent mouse shortcuts from being used.

Heyho,

thanks for the hint. It is not related to the XAllowEvents call I suspected in
the first place after all.

I now checked the original focusonclick[0] patch against the current git master,
6.1, 6.0 and 5.9 and the behavior is the same on all of them: MOD + Left-click +
drag to put a client into floating mode and move it does not work anymore. This
also is the case for MOD + Right-click + drag. So the patch has this regression
for quite a while now (as mentioned in the notes of your patch). It also does
not work with multiple monitors (they are still focused sloppily) which was my
original intention to fix.

Your own patch from the second link seems to fix the MOD-drag problem, so I'll
update it to also support multiple monitors (can test tonight when I have my
other monitor available again), add the switch to config.def.h and put it on the
wiki.

--Markus


0: http://dwm.suckless.org/patches/dwm-focusonclick-6.0.diff
Received on Thu Jan 05 2017 - 08:07:28 CET

This archive was generated by hypermail 2.3.0 : Thu Jan 05 2017 - 08:12:16 CET