Re: [hackers] [sdhcp] [PATCH] Fix sent lease time on 64-bit systems

From: Dimitris Papastamos <sin_AT_2f30.org>
Date: Thu, 9 Feb 2017 22:20:24 +0000

On Thu, Feb 09, 2017 at 01:42:27PM -0800, Michael Forney wrote:
> The lease time option is defined in RFC 1533 to be a 32-bit unsigned
> integer. However, on 64-bit systems, unsigned long long is 64 bits, so
> hnput writes 8 bytes, the first 4 of which are 0.
>
> dnsmasq (and possibly other DHCP servers) only looks at the first 4
> bytes in the option, so interprets a lease time of 0. It then sets the
> lease time to a minimum of 120 seconds. This causes the server to expire
> the lease long before sdhcp attempts to renew it.

Applied, thanks!
Received on Thu Feb 09 2017 - 23:20:24 CET

This archive was generated by hypermail 2.3.0 : Thu Feb 09 2017 - 23:24:17 CET