Re: [hackers] [farbfeld] Overhaul Build-system || Laslo Hunhold

From: Quentin Rameau <quinq_AT_fifth.space>
Date: Thu, 30 Mar 2017 11:42:10 +0200

Hi Laslo,

> > > -PNGLIB = /usr/local/lib
> > > -PNGINC = /usr/local/include
> > > -
> > > -JPGLIB = /usr/local/lib
> > > -JPGINC = /usr/local/include
> >
> > Personally I think it's useful to have these separated. It is also
> > useful to specify PNGINC, JPGINC etc separately for building in
> > different environments.
>
> what moved me to put it all into one parameter was the thought that
> even if the png and jpg library are in different places (same with the
> includes) you can easily add two or more include/library search paths
> to the compiler with the I- and L-flags. In this sense, it was
> logical to me that having separate variables was overkill. Please
> tell me if I'm missing something.

Maybe you could at least use variables for that, like INCPATH/LIBPATH
and expand them into CFLAGS/LDFLAGS, just for convenience.

> What a shame I hit this mine. It's even easier to hit GNUisms in make
> than bashisms in Bash, and I really didn't give it enough thought and
> just used target-specific variables. I'll do some further testing with
> pmake (that's how the BSD-make is called on Gentoo) and fix my
> makefiles to be portable.
> Thanks for pointing out the issue and taking your time to write this
> E-mail.

pmake is Debian Linux port of NetBSD make (as stated in your ebuild I
guess), it's not a POSIX-compliant makefiles tester.
I'd recommend first trying to write your makefiles according to the
specs, then only test with different tools (so not only gmake/pmake,
but bmake etc.) which shouldn't take long if you wrote something
sensible in the first place.

I had a quick look at your Makefile and sent a separate fix if you want.

Enjoy!
Received on Thu Mar 30 2017 - 11:42:10 CEST