Re: [hackers] [scron] [PATCH 1/3] Just use simple linked list instead of queue.h

From: Anselm R Garbe <garbeam_AT_gmail.com>
Date: Wed, 12 Jul 2017 13:55:32 +0200

On 12 July 2017 at 12:01, Dimitris Papastamos <sin_AT_2f30.org> wrote:
> On Tue, Jul 11, 2017 at 10:49:53AM -0700, Michael Forney wrote:
>> On 7/11/17, Laslo Hunhold <dev_AT_frign.de> wrote:
>> > On Mon, 10 Jul 2017 21:55:40 -0700
>> > Michael Forney <mforney_AT_mforney.org> wrote:
>> >
>> > Hey Michael,
>> >
>> > what's wrong with queue.h?
>>
>> The simple linked list I proposed uses the same amount of code, and is
>> easier to understand because it isn't hidden behind a bunch of macros.
>>
>> What's the advantage of queue.h over what I proposed?
>
> the implementation is uninteresting either way i think. the advantage
> is that you can easily switch your code to use a different type of list
> if required. also many people are already familiar with these macros.

I'm in favour for explicit data structs if it is about lists or
queues. In the worst case, it could be compiled in weird environments
without 4.4BSD support.

BR,
Anselm
Received on Wed Jul 12 2017 - 13:55:32 CEST