Re: [hackers] [sbase][PATCH] fix segfault

From: Michael Forney <mforney_AT_mforney.org>
Date: Thu, 7 Sep 2017 14:23:02 -0700

On Thu, Sep 7, 2017 at 2:02 PM, Pieter Kockx <pieterkockx_AT_gmail.com> wrote:
> Hello hackers
>
> Get a segfault by typing:
> paste blabla

Thanks for the report and patch.

> It seems wise to scrutinize other calls to unescape() as well.

It looks like other tools that call unescape only do so on
command-line arguments (see
https://git.suckless.org/sbase/tree/cut.c#n179 for example).

What do you think about just moving unescape to right after `adelim =
EARGF(usage());`? The default value does not need escaping.

I checked the other calls of unescape in other tools and they seem to be okay.

> -- Pieter
Received on Thu Sep 07 2017 - 23:23:02 CEST

This archive was generated by hypermail 2.3.0 : Thu Sep 07 2017 - 23:24:20 CEST