Re: [hackers] [PATCH][sbase] Add patch(1)

From: Silvan Jegen <s.jegen_AT_gmail.com>
Date: Mon, 11 Sep 2017 21:07:58 +0200

On Mon, Sep 11, 2017 at 08:57:02PM +0200, Mattias Andrée wrote:
> On Mon, 11 Sep 2017 20:09:33 +0200
> Silvan Jegen <s.jegen_AT_gmail.com> wrote:
>
> >> +when comparing directories. If however, the
> >
> > There should probably be an additional comma like this:
> >
> > "If, however, the file..."
>
> I think “However, if the file...” is better.

Sounds good to me!


> > > +portion of a patch. A patch is a signal
> > > +file-comparison output from
> >
> > Not sure what a "signal file-comparison output" is... is this official
> > POSIX/patch terminology?
>
> s/signal/singel/, so a patch file includes
> a patchset with is a number of patches, one
> per file in the patch file.

Haha, I totally didn't think of that...

 
> >> +Symbolic links are treated as regular files,
> >> +provided that they lead to regular files.
> >
> > maybe s/lead/link/ ?
>
> Not sure, perhaps “link” sounds more natural,
> but for me, ”link” means we are talking about
> the step and not the final step when following
> the link. However, I will add this change.

I think both are understandable but the term "link" for symbolic links
is definitely the more common one, I would say.

Received on Mon Sep 11 2017 - 21:07:58 CEST

This archive was generated by hypermail 2.3.0 : Mon Sep 11 2017 - 21:12:34 CEST