Re: [hackers] [slstatus] Simplify Makefile

From: Quentin Rameau <quinq_AT_fifth.space>
Date: Mon, 18 Sep 2017 09:16:49 +0200

> Dear Laslo, dear Quentin,

Hi Aaron,

> > why not just the following? Thanks for bringing the topic up; for
> > some reason I had in mind that it was necessary to list the
> > dependencies explicitly.
>
> I will merge this patch as it has the required dependency on
> slstatus.o and it is generally simpler.
> Thank you very much!

I think you missed some of the points of the patch...

My patched fixed the dependencies on the slstatus object,
there's no need to have all objects depend on util.h,
there's no need to override the inference rule .o:,
the dist target is missing some files.

It's not about apparent “simplicity”, it's about correctness.
Do the right thing!

-- Quentin
Received on Mon Sep 18 2017 - 09:16:49 CEST