Re: [hackers] [sbase][PATCH] patch: improvments suggested by Silvan

From: Silvan Jegen <s.jegen_AT_gmail.com>
Date: Mon, 25 Sep 2017 08:39:05 +0200

Hi Mattias

On Sun, Sep 24, 2017 at 8:20 PM, Mattias Andrée <maandree_AT_kth.se> wrote:
> On Sun, 24 Sep 2017 11:12:35 -0700
> Michael Forney <mforney_AT_mforney.org> wrote:
>
>> Hi Mattias,
>>
>> Instead of sending these patches on top of your original patch, can
>> you send amended versions (v2, v3, etc)? You can use `git format-patch
>> -v 2` to make this clear in the subject.
>>
>> I think that this would make it easier to review and keep track of your patch.
>>
>> Thanks!
>>
>
> Hi Michael!
>
> I thought it would be easier to see the changes I make.
> I think an amended version makes more sense when it's
> time to merge.

I would prefer an amended version of the patch as well. You could
mention the changes between the versions under the '---' separator
like it's done here (that way the change comments don't get picked up
by 'git am'): https://lkml.org/lkml/2017/9/25/19
Received on Mon Sep 25 2017 - 08:39:05 CEST

This archive was generated by hypermail 2.3.0 : Mon Sep 25 2017 - 08:48:21 CEST