On Sun, 1 Oct 2017 at 14:16:26 +0200, Hiltjo Posthuma wrote:
> Regarding the patch: [st][PATCH 05/23] Move ISO 14755 handling into x.c
> This does not seem X11-specific to me, can this be added/stay in st.c? Why
> was this separated?
This was moved into x.c because it used xwinid(), and doing so allowed
us to make the X window ID completely internal to x.c.
It also made sense to me to consider input methods as part of the user
interface rather than the terminal emulation. But I guess I could see
it in either place.
> In addition I think the fontconfig include can be (re)moved from st.c also
> right?
> #include <fontconfig/fontconfig.h>
Correct, along with a number of other includes. I have continued to
work on the refactoring at [1] (now up to -93 lines from master), and
this include has been removed.
[1]:
https://github.com/djpohly/st/commits/refactor2
Thanks,
*dp
--
<><
Received on Wed Oct 04 2017 - 07:15:35 CEST