Re: [hackers] [lsw][patch] Better handling of window title with non-ascii chars

From: Hiltjo Posthuma <hiltjo_AT_codemadness.org>
Date: Fri, 24 Nov 2017 12:35:12 +0100

On Wed, Nov 22, 2017 at 10:47:39PM +0100, Julien Steinhauser wrote:
> Hello
>
> I've seen window title with non-ascii chars incorrectly displayed,
> using Xutf8TextPropertyToTextList instead of XmbTextPropertyToTextList
> as in the diff below fixed it.
>
> Regards
>
> Julien
>
> diff --git a/lsw.c b/lsw.c
> index fc40fef..9a5bee1 100644
> --- a/lsw.c
> +++ b/lsw.c
> _AT_@ -55,7 +55,7 @@ getname(Window win) {
> if(!XGetTextProperty(dpy, win, &prop, netwmname) || prop.nitems == 0)
> if(!XGetWMName(dpy, win, &prop) || prop.nitems == 0)
> return "";
> - if(!XmbTextPropertyToTextList(dpy, &prop, &list, &n) && n > 0) {
> + if(!Xutf8TextPropertyToTextList(dpy, &prop, &list, &n) && n > 0) {
> strncpy(buf, list[0], sizeof buf);
> XFreeStringList(list);
> } else
>

Hey,

Which OS, libc and locale do you use?
uname -a, locale, libc + version?

On both OpenBSD and Linux glibc with UTF-8 locale it should not be needed.

-- 
Kind regards,
Hiltjo
Received on Fri Nov 24 2017 - 12:35:12 CET

This archive was generated by hypermail 2.3.0 : Fri Nov 24 2017 - 12:36:27 CET