Re: [hackers] [dmenu] Instantiate j var outside #ifdef XINEMARA directive because it is used in loop outside directive || Vincent Carluer

From: Hiltjo Posthuma <hiltjo_AT_codemadness.org>
Date: Thu, 4 Jan 2018 23:48:43 +0100

On Thu, Jan 04, 2018 at 07:14:27PM +0100, Jochen Sprickerhof wrote:
> j doesn't need initialization, so here is V2.

> From 0c1c5014b0a413df9591f37a987afbc5cd626c32 Mon Sep 17 00:00:00 2001
> From: Jochen Sprickerhof <git_AT_jochen.sprickerhof.de>
> Date: Thu, 4 Jan 2018 19:02:00 +0100
> Subject: [PATCH] =?UTF-8?q?Fix=20warning:=20=E2=80=98i=E2=80=99=20may=20be?=
> =?UTF-8?q?=20used=20uninitialized=20in=20this=20function?=
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> This was a regression of 84a1bc5.
> ---
> dmenu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dmenu.c b/dmenu.c
> index 3c261c0..c89067e 100644
> --- a/dmenu.c
> +++ b/dmenu.c
> _AT_@ -541,7 +541,7 @@ run(void)
> static void
> setup(void)
> {
> - int x, y, i, j = 0;
> + int x, y, i = 0, j;
> unsigned int du;
> XSetWindowAttributes swa;
> XIM xim;
> --
> 2.15.1
>

Thanks applied with a minor change.

-- 
Kind regards,
Hiltjo

Received on Thu Jan 04 2018 - 23:48:43 CET

This archive was generated by hypermail 2.3.0 : Fri Jan 05 2018 - 00:00:36 CET