On Mon, Jan 15, 2018 at 02:33:20PM -0500, Drew DeVault wrote:
> On 2018-01-15 , Hiltjo Posthuma wrote:
> > This looks too complicated for what it should do to me.
> > You also added functionality (like a -d) option. This should be separated in
> > a different patch.
>
> This functionality is not unrelated. Perhaps you'd rather have the
> passwd change and the login change in separate patches?
>
It is unrelated: logging in without a password is different from deleting a
password. The -d option looks like bloat to me, so should be left out imho.
The patches should be cleaned up.
--
Kind regards,
Hiltjo
Received on Tue Jan 16 2018 - 00:18:10 CET