Re: [hackers] [dwm][PATCH] ColBorder has been moved to the enum with ColFg and ColBg.

From: Silvan Jegen <s.jegen_AT_gmail.com>
Date: Fri, 16 Mar 2018 09:03:28 +0100

On Thu, Mar 15, 2018 at 10:38 PM, Eric Pruitt <eric.pruitt_AT_gmail.com> wrote:
> On Thu, Mar 15, 2018 at 10:17:25PM +0100, Silvan Jegen wrote:
>> Still sounds to me like having patches as attachments just causes me to
>> have to change my default configuration though.
>
> Change the world or change your configuration: the choice is yours! By
> adding a handful of bytes to your Mutt files, you can get the patches to
> effectively be inlined regardless of how the sender actually sent them.

Yeah, I can live with changing my mutt config in this case...


>> What is the advantage of attaching the patches instead of just sending
>> them inline, I wonder.
>
> I think a large part of what people prefer will depend on how they
> access the mailing list. I imagine it's easier for most common mail
> clients to deal with inline patches when it comes to reviewing &
> commenting, but I prefer attachments because:
>
> - They're easier for me to send. The various mail functions that Git
> provides make some assumptions about one's MUA that, IMO, make it
> tedious (albeit scriptable) to use them with Mutt for **sending**
> patches. If the machine I'm using isn't configured to send emails,
> it's easier for me to move a patch / diff file between machines rather
> than a Git-generated email that I'll have to re-edit to fix things
> like the "From:" header.

It's true that I have to fixup the headers but sending is handled
quite conveniently by "git send-email" (after it has been configured).
Just pass the directory containing the patches or the patch file names
as arguments to it and off you go. As you pointed out, it's also
easily scriptable.


> - I've seen inline patches get munged by MUAs. I have personally sent
> some broken patches because I forgot to disable automatic text
> wrapping of an email with an inline patch.

Obviously that doesn't happen with send-email.


> - When people send batches of related patches, sending a single email
> means that all of the patches will be immediately accessible whereas
> separate emails might not arrive in close proximity to one another or
> even in order because of things like rate limit and spam
> countermeasures.

While true in theory, in practice send-email threads a series of
patches so that they will always show up in the right order (provided
they were not spam-filtered and that your MUA supports email threads).


Cheers,

Silvan
Received on Fri Mar 16 2018 - 09:03:28 CET