[hackers] [slstatus][patch] consistent calculation of ram_* on openbsd

From: Tobias Tschinkowitz <he4d_AT_posteo.de>
Date: Wed, 16 May 2018 09:57:38 +0200

Just to add a little more consistency in the calculation...

Greets,
Tobias

---
 components/ram.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git components/ram.c components/ram.c
index 1178837..57081d2 100644
--- components/ram.c
+++ components/ram.c
_AT_@ -60,6 +60,7 @@
 	#include <unistd.h>
 
 	#define LOG1024 	10
+	#define pagetok(size, pageshift) ((size) << (pageshift - LOG1024))
 
 	inline int
 	load_uvmexp(struct uvmexp *uvmexp)
_AT_@ -81,7 +82,7 @@
 
 		if (load_uvmexp(&uvmexp)) {
 			free_pages = uvmexp.npages - uvmexp.active;
-			free = (float)(free_pages << (uvmexp.pageshift - LOG1024)) / 1024 / 1024; 
+			free = (float)(pagetok(free_pages, uvmexp.pageshift)) / 1024 / 1024;
 			return bprintf("%f", free);
 		}
 
_AT_@ -109,7 +110,7 @@
 		float total;
 
 		if (load_uvmexp(&uvmexp)) {
-			total = (float)(uvmexp.npages << (uvmexp.pageshift - LOG1024)) / 1024 / 1024; 
+			total = (float)(pagetok(uvmexp.npages, uvmexp.pageshift)) / 1024 / 1024;
 			return bprintf("%f", total);
 		}
 
_AT_@ -123,8 +124,7 @@
 		float used;
 
 		if (load_uvmexp(&uvmexp)) {
-			used = (double) (uvmexp.active * uvmexp.pagesize) /
-			       1024 / 1024 / 1024;
+			used = (float)(pagetok(uvmexp.active, uvmexp.pageshift)) / 1024 / 1024;
 			return bprintf("%f", used);
 		}
 
-- 
2.16.2

Received on Wed May 16 2018 - 09:57:38 CEST