Re: [hackers] [PATCH slstatus V2] Add basic backlight percentage support

From: Aaron Marcher <me_AT_drkhsh.at>
Date: Mon, 21 May 2018 13:09:08 +0200

David,

Thank you very much for your great work!
works great so far but I have just a few things for you to change.

 - Remove the "%" sign from the return
 - Fix the indention and spacing between the #ifdefs (see other
   components)
 - Move <stddef.h> in the Linux block as there is no other block to
   share code with
 - Add backlight_perc to config.def.h documentation (with acpi_video0 as
   example)
 - Add backlight_perc to README

Also: for now we will add only OpenBSD support as FreeBSD is no port
goal for version 1.

Regards,
Aaron

-- 
Web: https://drkhsh.at/ or http://drkhsh5rv6pnahas.onion/
Gopher: gopher://drkhsh.at or gopher://drkhsh5rv6pnahas.onion
GPG: 0x7A65E38D55BE96FE
Fingerprint: 4688 907C 8720 3318 0D9F AFDE 7A65 E38D 55BE 96FE
Received on Mon May 21 2018 - 13:09:08 CEST

This archive was generated by hypermail 2.3.0 : Mon May 21 2018 - 13:12:25 CEST