[hackers] [slstatus] Explicitly list component-objects in the Makefile || Laslo Hunhold

From: <git_AT_suckless.org>
Date: Sun, 27 May 2018 22:55:42 +0200 (CEST)

commit 0efd64ffaa04715eff9c834c437562952c4531cd
Author: Laslo Hunhold <dev_AT_frign.de>
AuthorDate: Sun May 27 22:40:00 2018 +0200
Commit: Aaron Marcher <me_AT_drkhsh.at>
CommitDate: Sun May 27 22:55:15 2018 +0200

    Explicitly list component-objects in the Makefile
    
    There was a long tinkering process at farbfeld about this, but the sad
    truth is that it's the only way to make the Makefile truly portable.
    Listing it just as
    
       $(COM:=.o): config.mk $(REQ:=.h)
    
    omits the dependency on the c-file itself, which incurs that strictly
    speaking the object file is not depending on the source file, which is
    nonsense.
    
    You don't see strictly Posix compliant Makefiles around very often and
    most use nasty GNU-extensions everywhere. It is a good idea to go ahead
    as a fitting example and show how to write them portably.

diff --git a/Makefile b/Makefile
index b2b75b4..8c6f170 100644
--- a/Makefile
+++ b/Makefile
_AT_@ -30,19 +30,38 @@ COM =\
 
 all: slstatus
 
-slstatus: slstatus.o $(COM:=.o) $(REQ:=.o)
+components/battery.o: components/battery.c config.mk $(REQ:=.h)
+components/cpu.o: components/cpu.c config.mk $(REQ:=.h)
+components/datetime.o: components/datetime.c config.mk $(REQ:=.h)
+components/disk.o: components/disk.c config.mk $(REQ:=.h)
+components/entropy.o: components/entropy.c config.mk $(REQ:=.h)
+components/hostname.o: components/hostname.c config.mk $(REQ:=.h)
+components/ip.o: components/ip.c config.mk $(REQ:=.h)
+components/kernel_release.o: components/kernel_release.c config.mk $(REQ:=.h)
+components/keyboard_indicators.o: components/keyboard_indicators.c config.mk $(REQ:=.h)
+components/keymap.o: components/keymap.c config.mk $(REQ:=.h)
+components/load_avg.o: components/load_avg.c config.mk $(REQ:=.h)
+components/netspeeds.o: components/netspeeds.c config.mk $(REQ:=.h)
+components/num_files.o: components/num_files.c config.mk $(REQ:=.h)
+components/ram.o: components/ram.c config.mk $(REQ:=.h)
+components/run_command.o: components/run_command.c config.mk $(REQ:=.h)
+components/swap.o: components/swap.c config.mk $(REQ:=.h)
+components/temperature.o: components/temperature.c config.mk $(REQ:=.h)
+components/uptime.o: components/uptime.c config.mk $(REQ:=.h)
+components/user.o: components/user.c config.mk $(REQ:=.h)
+components/volume.o: components/volume.c config.mk $(REQ:=.h)
+components/wifi.o: components/wifi.c config.mk $(REQ:=.h)
 slstatus.o: slstatus.c slstatus.h arg.h config.h config.mk $(REQ:=.h)
-$(COM:=.o): config.mk $(REQ:=.h)
+
+.c.o:
+ $(CC) -o $_AT_ -c $(CPPFLAGS) $(CFLAGS) $<
 
 config.h:
         cp config.def.h $_AT_
 
-.o:
+slstatus: slstatus.o $(COM:=.o) $(REQ:=.o)
         $(CC) -o $_AT_ $(LDFLAGS) $< $(COM:=.o) $(REQ:=.o) $(LDLIBS)
 
-.c.o:
- $(CC) -o $_AT_ -c $(CPPFLAGS) $(CFLAGS) $<
-
 clean:
         rm -f slstatus slstatus.o $(COM:=.o) $(REQ:=.o)
 
Received on Sun May 27 2018 - 22:55:42 CEST